This is an archive of the discontinued LLVM Phabricator instance.

Differential D21581

[libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.
ClosedPublic

Authored by STL_MSFT on Jun 21 2016, 5:48 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

Silence unused variable warnings in invoke.pass.cpp.

Fixes MSVC warning C4101 "unreferenced local variable".

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 61474.Jun 21 2016, 5:48 PM
STL_MSFT retitled this revision from to [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 21 2016, 6:01 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2016, 6:01 PM
EricWF closed this revision.Jun 21 2016, 6:05 PM

For some reason your patch wouldn't apply, but I committed my own version in r273348.

STL_MSFT added a subscriber: STL_MSFT.Jun 21 2016, 6:15 PM

Oops, that's because it touched the same file as my "avoid C++17 terse static_assert" patch, which hadn't been accepted yet. Thanks for fixing it up.

STL

Revision Contents

PathSize
test/
std/
utilities/
function.objects/
func.invoke/
2 lines

Diff 61474

test/std/utilities/function.objects/func.invoke/invoke.pass.cpp

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines
struct MemberObj { struct MemberObj {
int x; int x;
}; };
void noexcept_test() { void noexcept_test() {
{ {
NoThrowCallable obj; NoThrowCallable obj;
((void)obj); // Prevent unused warning
CopyThrows arg; CopyThrows arg;
static_assert(noexcept(std::invoke(obj)), ""); static_assert(noexcept(std::invoke(obj)), "");
static_assert(!noexcept(std::invoke(obj, arg)), ""); static_assert(!noexcept(std::invoke(obj, arg)), "");
static_assert(noexcept(std::invoke(obj, std::move(arg))), ""); static_assert(noexcept(std::invoke(obj, std::move(arg))), "");
} }
{ {
ThrowsCallable obj; ThrowsCallable obj;
((void)obj); // Prevent unused warning
static_assert(!noexcept(std::invoke(obj)), ""); static_assert(!noexcept(std::invoke(obj)), "");
} }
{ {
MemberObj obj{42}; MemberObj obj{42};
static_assert(noexcept(std::invoke(&MemberObj::x, obj)), ""); static_assert(noexcept(std::invoke(&MemberObj::x, obj)), "");
} }
} }
int main() { int main() {
bullet_one_two_tests(); bullet_one_two_tests();
bullet_three_four_tests(); bullet_three_four_tests();
bullet_five_tests(); bullet_five_tests();
noexcept_test(); noexcept_test();
} }