Sort and SortField Added #148
Conversation
Copied ISort.as FlexSDK->Royale
Sort,SortField,ISortField Copied FlexSDK->Royale
Added SortError.as FlexSDK->Royale
Update SortError.as
Update Sort.as
Update SortField
Update MXRoyaleClasses.as
|
Alina, Please comment out or delete any APIs and code that are not being used by your application. We have enough other code paths to migrate that we don't want to take on things we don't need to. |
|
Sort and SortField are API's used by my Application . Sort implements ISort and SortField implements ISortField. SortError used in SortField. It was easy to create emulation for ISort , ISortField & SortError. What if my Application is using a method api1.fn_functionName():api2 |
|
According to your API Report, some APIs in Sort and SortField like "unique", "reverse" and others are not being used by your app. Those APIs should be commented out for now so there is less code that we have to get working. Sort and SortField are being used by your application so it is fine to have these emulated, but we should not bring over APIs in those classes that are not being used. |
Update Sort.as
There was a problem hiding this comment.
This is better, but I expected to see changes to SortField as well, and also ISort and ISortField. I think Sort will need to continue to implement ISort.
I would like to understand better your thought process as you made these changes. Maybe you haven't fully grasped what interfaces are and how they work, which is understandable if you are new to languages that support Interfaces. You can email me in private if you don't want to discuss that publicly. I'm wondering if a better feel for these concepts will help you make better decisions.
Commented :
import mx.resources.IResourceManager;
import mx.resources.ResourceManager;