Build script cleanup #30345
Build script cleanup #30345
Conversation
tmat
commented
Oct 5, 2018
•
tmat
commented
- Move Linux build logic to build\scripts\build.sh
- Eliminate MicroBuild scripts
|
@jaredpar PTAL |
build/scripts/build.ps1
Outdated
| @@ -46,20 +46,19 @@ param ( | |||
| # Special test options | |||
| [switch]$testDeterminism = $false, | |||
|
|
|||
| [parameter(ValueFromRemainingArguments=$true)] $badArgs) | |||
| [parameter(ValueFromRemainingArguments=$true)][String[]]$properties) | |||
| @@ -16,9 +16,10 @@ | |||
|
|
|||
| [CmdletBinding(PositionalBinding=$false)] | |||
| param ( | |||
| [string]$configuration = "Debug", | |||
There was a problem hiding this comment.
Is this just reflecting the arcade model?
There was a problem hiding this comment.
Yes. I was thinking we could keep -release as well, if that's more convenient. On the other hand PowerShell allows to shorten and use e.g. -con Release, so perhaps it's not necessary. I don't think IDE devs are using release builds that often. Let me know if this is common pattern for compiler devs that we should keep a short command for.
There was a problem hiding this comment.
I don't think anyone uses it enough that it's worth keeping if arcade does it differently.
There was a problem hiding this comment.
:(
But I can find another way.
|
|
||
| if ($cibuild) { | ||
| # Symbol Uploader currently reports a warning for some files (https://github.com/dotnet/symstore/issues/76) | ||
| Run-MSBuild "build\Targets\RepoToolset\Publish.proj" "/t:Publish" -warnAsError:$false |
There was a problem hiding this comment.
Why do we want to be publishing during a PR?
There was a problem hiding this comment.
For validation (Dry Run) of the symbol uploader.
|
test ci please |
|
test ci please |
|
test this please |
|
test ci please |
|
FYI: test ci doesn't do any work now that we are on ADO. Need to manually requeue jobs via the UI. |
|
It does not affect Jenkins either? |
|
ok, that's what i expected. |
