Make error codes smaller #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
-http
-tls
-transport
design
martinthomson
force-pushed
the
smaller-errors
branch
from
067a9e7
to
ec77194
Compare
martinthomson
force-pushed
the
split-errors
branch
from
3f1867a
to
d687a9a
Compare
martinthomson
force-pushed
the
smaller-errors
branch
from
ec77194
to
b501b4d
Compare
janaiyengar
approved these changes
Sep 6, 2017
|
LGTM. I did the conflict resolution just to keep our PRs clean. |
mnot
removed
the
design
martinthomson
force-pushed
the
split-errors
branch
from
4fa1f68
to
78db6b2
Compare
martinthomson
force-pushed
the
smaller-errors
branch
from
2c77118
to
f7eb393
Compare
A friendly amendment to your PR.
Require that parameters only appear once.
Allow RST_STREAM to be sent and received after FIN
Must not ack acks
Clarify the first flight, explicitly excluding NST
* Split error code space This creates two orthogonal spaces for error codes. Application error codes can be used for both connection and stream errors and are under the control of the application protocol. Transport error codes are QUIC-controlled, but can only terminate the connection. To fix this, I had to add IANA considerations for error codes, plus a few extra tweaks. I think that the error code space could be narrowed to 16 bits after this, if only to keep things sane. Closes #132. * s/Public Reset/Stateless Reset/ * Get codes consistent * Make STOP_SENDING application-specific as well * Split errors in HTTP too * Refine description of HTTP codes * Move TLS errors closer * Match the names * Add HTTP_NO_ERROR * Review comments * Jana's comments * Small tweak at Mike's suggestion * Reword STOP_SENDING text to avoid implication of mandatory RST_STREAM * Better track changes on master * Reword advice on application error codes * Steal a code from the application * Simply reserve the RST_STREAM code of 0. * Application error code missed * We really should just call this STOPPING
martinthomson
force-pushed
the
smaller-errors
branch
from
f7eb393
to
d40549b
Compare
Remove Timestamps
the revision corresponding to the -06 drafts. It's still essentially arbitrary but now it's predictable arbitrary.
The change in #844 didn't mention the hash function used with HKDF. It is pretty obviously SHA-256, but we need to write that down. Also a few editorial changes.
Followup for cleartext AEAD change
Simplify stateless retry
Otherwise, version negotiation doesn't work.
Don't retransmit old MAX_STREAM_DATA and MAX_DATA
* error codes can be used with stop_sending
martinthomson
force-pushed
the
smaller-errors
branch
from
d40549b
to
8c08acc
Compare
|
Ahh, I see the problem now. @janaiyengar I will create a new PR for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #722, the error code space is much more tightly defined. We don't need the enormous space that we have. A 16-bit value is adequate.