We can close #874 I think, Ere's work is great and we should base this driver on it ;) thanks!

Great, thanks, @xmorave2; I'll take care of that now!

Do you know if Course Reserves will be included? As I noticed getCourses(), getInstructors(), and getDepartments() appear to be missing?

Updated to the latest version. This is a candidate for production use.

We don't use course reserves so I'm afraid that it'll be up to someone else to implement support for them.

When you say this is a candidate for production use, do you mean that things have stabilized on the Koha side and we should consider merging this? If so, one quick suggestion: maybe we should add a note to the driver list in config.ini specifying the minimum Koha version required for the driver.

What I mean is that the first Finnish Koha libraries are just about to go live with Finna (VuFind), but I think the mainline Koha is still missing most of the required API endpoints. See https://github.com/Koha-Community/Koha/tree/master/api/v1/swagger/paths compared to https://github.com/KohaSuomi/Koha/tree/ks-rumble/api/v1/swagger/paths. Unfortunately it looks like very little progress has been made on Koha-Community side to integrate the features.

Thanks for the clarification. I guess we'll leave it as a PR for now!

@EreMaijala, I've just merged the latest master into this and resolved conflicts. Any news on the progress of the API release? I notice that the ticket cited above appears not to have changed in the past year.

@demiankatz Thanks! The required APIs will probably be converted to an API plugin for Koha since there's now infrastructure to support that on the Koha side. No timeframe for that at the moment, unfortunately..

Good to know! Are there any tickets or other URLs we can watch in future for news on the progress of the plugin?

Not right now, but I'll make sure to link to any when they exist.

I'm now working on making the driver use Koha's existing REST APIs or API plugins whenever possible and adding a new API plugin for the rest of the needed functionality.

@EreMaijala Which enpoints are missing in Koha now do you think? I planned to start working on plugin for availability endpoint... That's the biggest issue for this drive I think...

@xmorave2 Availability is one, but but we also need at least the following:

• patron validation
• extensions to checkouts
• items
• checkout history

My work is still in progress, so there may be more and probably is.

@EreMaijala
For checkouts history I have a path here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
I am going to bring this proposal to Koha development meeting next week.

items should be implemented in Tomas's plugin for bibliocommons, I have it installed here: https://koha-devel-test.knihovna-uo.cz/api/v1/
And I can give you access for this testing instance if you want, we are using this instance for testing of connection Koha to Czech national library portal knihovny.cz (based on vufind).

@xmorave2 Unfortunately it seems to have the same design issue as normal checkouts, i.e. no support for paging the results. Especially the history can get huge, and without paging things just won't perform well.

With the latest commit I believe all the required functionality has been implemented with the help of the Koha API plugin. Still needs at least testing, and a new Koha release.

Thanks, @EreMaijala, just let me know when it's time to merge this... and whether you have any thoughts on if/when/how to retire either of the other Koha drivers. (I imagine will still need all three for at least some period of time). Hopefully @xmorave2 can help with testing, as well.

Yes, it would be great if @xmorave2 could help with testing. My environment is all completely fake data, so testing with e.g. an anonymized real database might uncover missing changes.

@EreMaijala, @demiankatz Of course, I could test it on more 'real' data. I'll try to do it as soon as possible. Reading the code it is looking solid, so I think there will be no major issues.

@xmorave2 I'm actually expecting there to be more issues in the Koha plugin...

I'm still working on the plugin adding some functionality we need locally. Some minor changes will follow.

I think I've now completed all the forementioned changes. @xmorave2, feel free to start testing whenever it's suitable for you! :)

Now that Laminas migration work has been merged to master, we should bring this PR up to date to match. Please let me know if you need any assistance from me.

All done now. And I've briefly tested the functionality with newly released Koha 20.05. This should be good to go now!

@demiankatz I believe I've addressed your comments. I'll leave deprecation of the old drivers up to you. I think it would make sense since the old APIs don't get much attention and using database access is often convoluted, but I don't want to force KohaRest use on anyone.