Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Autocomplete giving any info from non-visible fields #1285

Closed
alastc opened this issue Mar 7, 2018 · 6 comments · Fixed by #1372
Closed

Autocomplete giving any info from non-visible fields #1285

alastc opened this issue Mar 7, 2018 · 6 comments · Fixed by #1372
Assignees
Milestone

Comments

@alastc
Copy link

alastc commented Mar 7, 2018

This issue came up during some WCAG work, where we are potentially requiring authors to use autocomplete attributes.

It appears that a site can hide fields (off-screen with CSS) such as address & credit card so that if you select 'fill form' whilst on a name field, it gets all the other information without you realising.

Article with examples.

I assume the browser makers would want to address it, but it also affects other user-agents / extensions like password managers. For example, Lastpass has form-filling functilnality that is affected. (I think Lastpass uses more than the autocomplete tokens, but it certainly works on fields with autocomplete.)

There could be various solutions, but as a minimum user-agents should check that a field is visible before filling it in, can a warning or note be added to the spec?

@chaals chaals added this to the HTML5.3 WD3 milestone Apr 1, 2018
@chaals
Copy link
Collaborator

chaals commented Apr 1, 2018

I hope we can get something in before the next milestone. In case we don't I have flagged it so I can make sure it is picked up explicitly for privacy review.

@LJWatson
Copy link
Collaborator

LJWatson commented Apr 9, 2018

@alastc is it just when fields are hidden off-screen (per the examples linked from the article you referenced), or are there other techniques we should mention?

@alastc
Copy link
Author

alastc commented Apr 9, 2018

Logically it must be when fields (with autocomplete) are on the page, but hidden or disguised in some way.

There might be an aspect of wack-a-mole, where if hidden fields are detected by browsers then attackers might use other techniques like shrinking inputs to a couple of pixels, or making them transparent, or white on a white background or some other technique.

I suggest leaving it up to the browsers to fulfill a general requirement as they see fit.

@LJWatson
Copy link
Collaborator

LJWatson commented Apr 9, 2018

Thanks @alastc. Proposed text:

<Warning: When fields with the 'autofill' attribute are hidden off-screen or visually disguised, personal data may still be entered when using the 'auto-fill' feature of browsers and password managers. User agents should verify that all fields with the 'autofill' attribute are visible within the viewport before inserting data automatically.<

@johnfoliot
Copy link

johnfoliot commented Apr 10, 2018 via email

LJWatson added a commit that referenced this issue Apr 12, 2018
* Warns UAs to verify fields with autocomplete in the autofill expectation mantle are visible before automtically inserting data
* Will fix #1285
@LJWatson LJWatson self-assigned this Apr 12, 2018
@LJWatson
Copy link
Collaborator

Comment originally filed by email from Nick Doty, in response to a wide review request to the Privacy IG.

<"The warning on the autofill attribute seems particularly important. Do we know whether UAs have implemented mitigations for this threat? Are there mitigations
that should be included in future versions of the spec?"<

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants