Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

Remove concept of types, supportedTypes, BasicCardType enum #62

Merged
merged 3 commits into from Nov 15, 2018

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 1, 2018

closes #59

The following tasks have been completed:

Implementation commitments:

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox
  • Edge (public signal)

Preview | Diff

Copy link
Contributor

@ianbjacobs ianbjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one editorial suggestion; otherwise good to go.

index.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member Author

@rsolomakhin you probably saw, I sent a bunch of pull requests updating the tests. I hacked up your handler tests, so please make sure I didn't screw them up :)

@zouhir, heads up on the Microsoft side.

@rsolomakhin
Copy link
Collaborator

ACK

@zouhir
Copy link
Collaborator

zouhir commented Nov 4, 2018

👍

@marcoscaceres marcoscaceres mentioned this pull request Nov 4, 2018
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Nov 5, 2018

Oki, sent removal patch on the Gecko side...

@ianbjacobs
Copy link
Contributor

Call for consensus to remove sent today:
https://lists.w3.org/Archives/Public/public-payments-wg/2018Nov/0008.html

@ianbjacobs
Copy link
Contributor

@marcoscaceres,

I believe there are libraries that support Basic Card. We want to understand the impact of deprecating this feature on that deployed software. Perhaps the editors can reach consensus on appropriate browser behavior when they encounter this deprecated feature.

Thanks!

@marcoscaceres
Copy link
Member Author

Libraries would be unaffected in terms of behavior - passing in supportedTypes is ignored. And the spec makes no guarantees that the returned card is of the requested network or type, so nothing really changes there: the payment processor still needs to check that the user didn’t provide a bogus card.

@marcoscaceres marcoscaceres added the blocked Blocked waiting on something label Nov 6, 2018
@marcoscaceres
Copy link
Member Author

Blocked on CFC until 15th of November.

@marcoscaceres marcoscaceres removed the blocked Blocked waiting on something label Nov 14, 2018
@marcoscaceres marcoscaceres merged commit 35ab09e into gh-pages Nov 15, 2018
@marcoscaceres marcoscaceres deleted the remove_supportedTypes branch November 15, 2018 05:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop supportedTypes?
4 participants