Skip to content
This repository has been archived by the owner on Jun 30, 2018. It is now read-only.

The rewrite of label in name needs images of text #484

Closed
DavidMacDonald opened this issue Oct 9, 2017 · 16 comments
Closed

The rewrite of label in name needs images of text #484

DavidMacDonald opened this issue Oct 9, 2017 · 16 comments

Comments

@DavidMacDonald
Copy link
Contributor

DavidMacDonald commented Oct 9, 2017

it needs the addition of visible label:

For active user interface components with labels that include text <add>or images of text</add>, the name includes the text of the label.

The new wording dropped "visible label", and sometimes a visible label is an image, want to ensure this doesn't pass. <button aria-label="go"><img src="go.jpg"></button><input aria-label="search" ...>

Also, it needs a note about the string of text being at the beginning of the name.
Note:
<p class="note">A best practice is to place the text string that makes up the name, at the start of the text string that makes up the label.</p>

@awkawk
Copy link
Member

awkawk commented Oct 11, 2017

@DavidMacDonald I marked the example in your issue text as code because github was trying to render the image.

@joshueoconnor
Copy link
Contributor

@mraccess77
Copy link

I support adding images of text.

@awkawk
Copy link
Member

awkawk commented Oct 27, 2017

Discussed on 10/26 call and almost came to a conclusion. https://www.w3.org/2017/10/26-ag-minutes.html

Two proposals discussed were:

  • "For active user interface components with labels that include text, or images of text the name includes the text or the text in the image."
  • "For user interface components with labels, the name includes the text of the label, including any text alternatives for images of text."

The main concern about the first proposal was that the second half of the SC allows either of the forms of text to be included in the name, but if both types are present then both need to be included.

The main concern about the latter proposal was that a text alternative for an image of text might have information beyond the equivalent of the text itself and the goal is to only require the text content, whether it is in an image or in text.

@awkawk
Copy link
Member

awkawk commented Oct 27, 2017

What about:
The name for a user interface component includes text that matches the content of any text and images of text used to provide a label for the user interface component.

@steverep
Copy link
Member

@awkawk, I agree that the 2 proposals you quoted have issues, but I still don't understand what's wrong with the current pull request version (minus the "active"):

For user interface components with labels that include text or images of text, the name includes the text of the label.

That tries to say the same thing as your most recent offer, does it not? I think the complaint was that the second use of "text" could be taken confusingly since it refers to any text, regardless of whether or not it's an image. Perhaps that could just be clarified in a note or with a slight alteration like:

For user interface components with labels that include text or images of text, the name includes the text string as presented in the label.

I'd prefer keeping it clear that not all UI components have labels and not all labels have text or images of text rather than boiling that down to a single word ("any").

@steverep
Copy link
Member

... or even "character string"

@awkawk
Copy link
Member

awkawk commented Oct 27, 2017

I think that the source of the problem is that if people are confused that text in a label doesn't necessarily include images of text why wouldn't they be confused about what they are required to include in the name?

How about:
"For user interface components with labels that include content that is visually represented as text, the name includes that content."

And then we provide a definition for "visually represented as text":
A visual representation of a sequence of characters where the sequence is expressing something in human language. The representation is not necessarily programmatically determinable.

@steverep
Copy link
Member

I think that the source of the problem is that if people are confused that text in a label doesn't necessarily include images of text why wouldn't they be confused about what they are required to include in the name?

Well, yeah I agree but WCAG 2.0 shoots itself in the foot by defining "text" as being programmatically determinable, and then using "text" in the definition of "image of text" (straying from the dictionary causing problems sounds familiar...).

And then we provide a definition for "visually represented as text":

Do we really want to go down that road when we've already got definitions for text, image of text, non-text...?

How about just not using text in the second half and using the way it is defined as "sequence of characters":

For user interface components with labels that include text or images of text, the name contains the sequence of characters visually presented in the label.

@awkawk
Copy link
Member

awkawk commented Oct 27, 2017

I'm ok with that. Either way we will need to be clear in the understanding docs and have clarifying techniques.

@awkawk
Copy link
Member

awkawk commented Oct 30, 2017

Current proposal: For user interface components with labels that include text or images of text, the name contains the sequence of characters visually presented in the label.

@alastc
Copy link
Contributor

alastc commented Oct 31, 2017

Trying to simplify:

For user interface components with labels that include text or images of text, the name contains the text presented.

I.e. if you show text in whatever form, include it in the name. You could add 'visually' on the end, which would then exclude hidden labels, which would make sense for the voice-input scenario.

@johnfoliot
Copy link

johnfoliot commented Oct 31, 2017 via email

@awkawk
Copy link
Member

awkawk commented Oct 31, 2017

Version for CFC, as agreed by WG on 10/31/17 call: "For user interface components with labels that include text or images of text, the name contains the text presented."

@steverep
Copy link
Member

steverep commented Nov 1, 2017

Pull request #535 has been updated with the CFC wording.

@awkawk
Copy link
Member

awkawk commented Nov 5, 2017

Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants