Change in the language/direction infoset items #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt to be localizable
|
(The travis error can be ignored, it was the result of an unlucky manipulation with .travis.yml) |
index.html
Outdated
| <li>calculate the language using its own algorithm.</li> | ||
| </ul> | ||
|
|
||
| <p>If a language tag cannot be determined, the value "<code>und</code>" (undetermined) MUST be used.</p> | ||
| <p>If a language tag cannot be determined, the value "<code>und</code>" (undetermined) MUST be used. If the base direction cannot be determined, the value <code>ltr</code> MUST be assumed.</p> |
There was a problem hiding this comment.
oops... of course. Will take care of this.
lrosenthol
suggested changes
Feb 7, 2018
index.html
Outdated
| @@ -403,7 +402,7 @@ <h3>Requirements</h3> | |||
| <span>RECOMMENDED:</span> | |||
| <ul class="flat"> | |||
| <li><a href="#wp-a11y">accessibility</a></li> | |||
| <li><a href="#wp-dir">base direction</a></li> | |||
| <li><a href="#wp-language">base direction</a></li> | |||
There was a problem hiding this comment.
Why is this changed to language, it should still be dir?
There was a problem hiding this comment.
@lrosenthol the previous version contained two independent sections, one for language and another for direction. With the extra features it looked editorially better to merge the two sections. Hence the two identical targets.
The "id" value may not be ideal (just kept the old id of one of the original sections) but that is only an internal thing, invisible to the reader. We can harmonize those later.
This was referenced Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added/changed the language and direction section to allow for each text to be localizable, which led to a slight reorganization of the spec.
Refers to #124
Preview | Diff