Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyDetectProviderKeyPackageId regressed to no longer return success after finding first provider key #5803

Closed
MattHyman opened this issue Apr 26, 2018 · 5 comments
Closed

DependencyDetectProviderKeyPackageId regressed to no longer return success after finding first provider key #5803

MattHyman opened this issue Apr 26, 2018 · 5 comments
Labels
bug burn

Comments

@MattHyman
Copy link

DependencyDetectProviderKeyPackageId regressed to no longer return success after finding first provider key.

DependencyDetectProviderKeyPackageId was incorrectly refactored in a448a60ec8fe428058cc3ac01aeae1175b1d6402 to no longer return success after finding the first provider key. This results in incorrect provider behavior if there are multiple provider keys and the target one is not last.

  • Which version of WiX are you building with?
    3.11
@MattHyman
Copy link
Author

Preparing a PR for this now.

@rseanhall
Copy link
Contributor

Looks like the commit you're referencing is wixtoolset/wix3@a448a60. This sounds similar to wixtoolset/wix#218.

@MattHyman
Copy link
Author

PR is up at wixtoolset/wix3#464.

@BMurri
Copy link

BMurri commented May 7, 2018

Since this PR has been closed, and the issue apparently either doesn't exist in wix4 or was also fixed in v4, shouldn't this issue now be closed?

@robmen
Copy link
Member

robmen commented May 7, 2018

Agreed.

@robmen robmen closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug burn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@robmen @barnson @MattHyman @BMurri @rseanhall