Fix DependencyDetectProviderKeyPackageId to return on first GetProvid… #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erInformation success in for loop.
heaths
approved these changes
Apr 26, 2018
|
I was not aware of the previous fix in wix4 when I wrote this, I am willing to switch to that solution if we feel it is the right thing to do. |
…etProviderInformation success in for loop." This reverts commit 18d779a.
|
Switching to a cherry-pick of wixtoolset/wix#218. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DependencyDetectProviderKeyPackageId was incorrectly refactored in a448a60 to no longer return success after finding the first provider key. This results in incorrect provider behavior if there are multiple provider keys and the target one is not last.
This PR fixes the issue.